[pkg] Upgrade to @testing-library packages #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntucker
force-pushed
the
react-hooks-test-upgrade
branch
from
ab5f0d1 to
7f40977
Compare
ntucker
changed the title
ntucker
force-pushed
the
react-hooks-test-upgrade
branch
from
85c9633 to
50f5551
Compare
ntucker
force-pushed
the
react-hooks-test-upgrade
branch
from
50f5551 to
023ff45
Compare
ntucker
commented
Aug 14, 2019
| unstable_scheduleCallback, | ||
| // eslint-disable-next-line @typescript-eslint/camelcase | ||
| unstable_NormalPriority, | ||
| } from 'scheduler/unstable_mock'; |
There was a problem hiding this comment.
all testing with scheduler is done via this mock module rather than jest time mocking
There was a problem hiding this comment.
facebook/react#14964 << context
|
build currently failing because coveralls is down |
ntucker
changed the title
ntucker
commented
Aug 14, 2019
| @@ -0,0 +1,124 @@ | |||
| --- | |||
There was a problem hiding this comment.
these new files are just because they didn't change from 2.0 previously so it didn't create a copy
zacharyfmarion
approved these changes
Aug 14, 2019
mprobber
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional peerDeps have been added to reflect the needed testing library versions. These are optional because you don't have to use the testing part of rest-hooks.
Future work: 'rest-hooks/test' should be its own package so breaking changes can be separated.