Skip to content

Add a request for publishers that don't publish an error until requests #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a request for publishers that don't publish an error until requests #560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tck/src/main/java/org/reactivestreams/tck/PublisherVerification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,10 @@ public void run(final Publisher<T> pub) throws InterruptedException {
public void onSubscribe(Subscription subs) {
onSubscribeLatch.assertOpen("Only one onSubscribe call expected");
onSubscribeLatch.close();

// If the publisher requires a request to publish the error, that follows the spec
// If it does not, this should be a no-op
subs.request(1);
}
@Override
public void onError(Throwable cause) {
Expand Down Expand Up @@ -527,6 +531,10 @@ public void onError(Throwable cause) {
public void onSubscribe(Subscription subs) {
onSubscribeLatch.assertOpen("Only one onSubscribe call expected");
onSubscribeLatch.close();

// If the publisher requires a request to publish the error, that follows the spec
// If it does not, this should be a no-op
subs.request(1);
}
};
pub.subscribe(sub);
Expand Down