Skip to content

Fix flask backend mimetype for modules #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2023
Merged

Fix flask backend mimetype for modules #1131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7bae43
Fix flask backend mimetype for modules
elro444 Aug 15, 2023
552ea13
Update changelog
elro444 Aug 15, 2023
8c7bbac
Merge branch 'main' into fix-flask-backend-mimetype
rmorshea Oct 22, 2023
eb02c5d
Merge branch 'main' into fix-flask-backend-mimetype
rmorshea Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/source/about/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Unreleased
**Fixed**

- :pull:`1118` - `module_from_template` is broken with a recent release of `requests`
- :pull:`1131` - `module_from_template` did not work when using Flask backend


v1.0.2
Expand Down
2 changes: 1 addition & 1 deletion src/py/reactpy/reactpy/backend/flask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def send_assets_dir(path: str = "") -> Any:

@api_blueprint.route(f"/{MODULES_PATH.name}/<path:path>")
def send_modules_dir(path: str = "") -> Any:
return send_file(safe_web_modules_dir_path(path))
return send_file(safe_web_modules_dir_path(path), mimetype="text/javascript")

index_html = read_client_index_html(options)

Expand Down