- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 331
Update PR workflow / workspace #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 24 commits
      Commits
    
    
            Show all changes
          
          
            33 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      604bc32
              
                Add VS Code config
              
              
                Archmonger 1919158
              
                Change pull request template
              
              
                Archmonger e2feeb3
              
                remove isort
              
              
                Archmonger 1ce169d
              
                add ruff
              
              
                Archmonger 3bd8b69
              
                subtext
              
              
                Archmonger 36bc76c
              
                update PR comments
              
              
                Archmonger f9cb181
              
                remove github projects link
              
              
                Archmonger 9b09ae3
              
                Add s
              
              
                Archmonger 3226177
              
                add more extensions
              
              
                Archmonger ddeb91f
              
                Merge remote-tracking branch 'upstream/main' into workspace-config
              
              
                Archmonger c63219d
              
                remove subjective extensions
              
              
                Archmonger a2e2418
              
                remove py-tpl
              
              
                Archmonger ca61e74
              
                set black as default formatter
              
              
                Archmonger 2062f06
              
                Update .github/pull_request_template.md
              
              
                Archmonger 9eb7226
              
                Merge branch 'main' into workspace-config
              
              
                rmorshea 8e1fb38
              
                re-add vscode to gitignore
              
              
                Archmonger cb940f0
              
                Merge branch 'main' into workspace-config
              
              
                Archmonger afa0b5f
              
                Merge remote-tracking branch 'upstream/main' into workspace-config
              
              
                Archmonger 4a14d5c
              
                Merge branch 'main' into workspace-config
              
              
                rmorshea ba4845a
              
                remove auto import completion
              
              
                Archmonger 88818f9
              
                Update pull request template
              
              
                Archmonger 926211e
              
                remove stuff
              
              
                Archmonger 9e9664c
              
                sort json
              
              
                Archmonger 9d71dc6
              
                Merge branch 'main' into workspace-config
              
              
                Archmonger 0be93c7
              
                remove newly deprecated settings
              
              
                Archmonger 30b09eb
              
                Merge branch 'workspace-config' of https://github.com/Archmonger/reac…
              
              
                Archmonger cdadb0d
              
                remove jinja associations
              
              
                Archmonger 3996ae6
              
                Remove settings.json
              
              
                Archmonger ae55330
              
                Merge branch 'main' into workspace-config
              
              
                Archmonger 200ae13
              
                Update pull request template
              
              
                Archmonger f6b6cd2
              
                Merge branch 'main' into workspace-config
              
              
                Archmonger 131fe0a
              
                Misc cleanup
              
              
                Archmonger aac0dc2
              
                Merge branch 'workspace-config' of https://github.com/Archmonger/reac…
              
              
                Archmonger File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,14 +1,15 @@ | ||
| <sub>By submitting this pull request you agree that all contributions to this project are made under the MIT license.</sub> | ||
|  | ||
| ## Issues | ||
|  | ||
| <!-- Describe or link the issues this change resolves --> | ||
|  | ||
| ## Solution | ||
|  | ||
| <!-- Describe how these changes resolve the aforementioned issues --> | ||
| <!-- Describe how these changes resolves the issues --> | ||
|  | ||
| ## Checklist | ||
|  | ||
| - [ ] Tests have been included for all bug fixes or added functionality. | ||
| - [ ] The `changelog.rst` has been updated with any significant changes. | ||
| - [ ] Tests have been included for all bug fixes or added functionality. | ||
| - [ ] The `changelog.rst` has been updated with any significant changes. | ||
| - [ ] The documentation has been updated, if needed. | ||
|  | ||
| <sub>By submitting this pull request you agree that all contributions are made under this project's open source license(s).</sub> | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "recommendations": [ | ||
| "wholroyd.jinja", | ||
| "esbenp.prettier-vscode", | ||
| "ms-python.vscode-pylance", | ||
| "ms-python.python", | ||
| "charliermarsh.ruff", | ||
| "dbaeumer.vscode-eslint", | ||
| "ms-python.black-formatter", | ||
| "ms-python.mypy-type-checker" | ||
| ] | ||
| } | 
|         
                  Archmonger marked this conversation as resolved.
              Outdated
          
            Show resolved
            Hide resolved | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| { | ||
| "[css]": { | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode" | ||
| }, | ||
| "[javascript]": { | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode" | ||
| }, | ||
| "[json]": { | ||
| "editor.defaultFormatter": "vscode.json-language-features" | ||
| }, | ||
| "[python]": { | ||
| "editor.codeActionsOnSave": { | ||
| "source.organizeImports": true | ||
| } | ||
| }, | ||
| "editor.detectIndentation": false, | ||
| "editor.formatOnSave": true, | ||
| "files.associations": { | ||
| "**/template/**.html": "jinja", | ||
| "**/templates/**.html": "jinja" | ||
| }, | ||
| "files.insertFinalNewline": true, | ||
| "git.autofetch": "all", | ||
| "prettier.endOfLine": "auto", | ||
| "prettier.proseWrap": "never", | ||
| "prettier.tabWidth": 4, | ||
| "python.analysis.typeCheckingMode": "off", | ||
| "python.formatting.provider": "black", | ||
| "python.languageServer": "Pylance", | ||
| "python.linting.enabled": true | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.