- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 331
Warn and fix missing mime types #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            18 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      674c570
              
                Fix Windows mime types bug
              
              
                Archmonger 6f14207
              
                add changelog
              
              
                Archmonger 7303c27
              
                fix lint
              
              
                Archmonger d0c4d6a
              
                use static mime types
              
              
                Archmonger 9ba85bd
              
                remove mime types we don't immediately need
              
              
                Archmonger 1b42e32
              
                add no cov pragma
              
              
                Archmonger a6f7341
              
                format
              
              
                Archmonger e95f839
              
                try to remove one pragma
              
              
                Archmonger 13902cc
              
                Add logger warning
              
              
                Archmonger efd2b3a
              
                better comment
              
              
                Archmonger 8dad923
              
                format
              
              
                Archmonger dd938d3
              
                use lazy logging
              
              
                Archmonger 04fccde
              
                OS-neutral comment
              
              
                Archmonger 4152a32
              
                update changelog verbiage
              
              
                Archmonger f261c50
              
                Merge remote-tracking branch 'upstream/main' into fix-mime-type
              
              
                Archmonger 228af5b
              
                Link example issue
              
              
                Archmonger a9aace5
              
                Update src/py/reactpy/reactpy/backend/__init__.py
              
              
                Archmonger 7aa6fc4
              
                add: attempt to fix
              
              
                Archmonger File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import mimetypes | ||
| from logging import getLogger | ||
|  | ||
| _logger = getLogger(__name__) | ||
|  | ||
| # Fix for missing mime types due to OS corruption/misconfiguration | ||
| # Example: https://github.com/encode/starlette/issues/829 | ||
| if not mimetypes.inited: | ||
| mimetypes.init() | ||
| for extension, mime_type in { | ||
| ".js": "application/javascript", | ||
| ".css": "text/css", | ||
| ".json": "application/json", | ||
| }.items(): | ||
| if not mimetypes.types_map.get(extension): # pragma: no cover | ||
| _logger.warning( | ||
| "Mime type '%s = %s' is missing. Please research how to " | ||
| "fix missing mime types on your operating system.", | ||
| extension, | ||
| mime_type, | ||
| ) | ||
| mimetypes.add_type(mime_type, extension) | ||
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.