Better Error message if no backend installed #1042 #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rmorshea merged 8 commits into reactive-python:main from geckguy:fix-1042

Jun 13, 2023

Contributor

geckguy commented Jun 12, 2023 •

edited by rmorshea

Loading

Issues

closes: #1042

Summary

Added a better error message stating that no backend is installed
Suggested list of supported backends (imported from reactpy.backend.utils)


          Better Error message if no backend installed reactive-python#1042

4da8305

rmorshea requested changes

View reviewed changes

src/py/reactpy/reactpy/backend/default.py Outdated Show resolved Hide resolved


          change the error message as requested

70b908a

Contributor Author

geckguy commented Jun 12, 2023

I have made the suggested changes, please do review

rmorshea reviewed

View reviewed changes

src/py/reactpy/reactpy/backend/default.py Outdated Show resolved Hide resolved


          Update src/py/reactpy/reactpy/backend/default.py

3efd27f

Co-authored-by: Ryan Morshead <ryan.morshead@gmail.com>

Collaborator

rmorshea commented Jun 12, 2023

It looks like there's some other linting issue. If you don't have a dev environment set up you can use this website to help format your code: https://play.ruff.rs/

Contributor Author

geckguy commented Jun 12, 2023

It looks like there's some other linting issue. If you don't have a dev environment set up you can use this website to help format your code: https://play.ruff.rs/

I was working in VScode with all the req dependencies installed

Collaborator

rmorshea commented Jun 12, 2023 •

edited

Loading

If you have a dev env setup you should be able to run hatch run lint-py --fix. It won't necessarily be able to fix everything though - to do a full check so you can resolve the other issue manually run hatch run lint-py


          fix linting issues

Contributor Author

geckguy commented Jun 12, 2023

If you have a dev env setup you should be able to run hatch run lint-py --fix. It won't necessarily be able to fix everything though - to do a full check so you can resolve the other issue manually run hatch run lint-py

Fixed it. Should be good now

rmorshea reviewed

View reviewed changes

src/py/reactpy/reactpy/backend/default.py Outdated Show resolved Hide resolved

rmorshea reviewed

View reviewed changes

src/py/reactpy/reactpy/backend/default.py Outdated Show resolved Hide resolved

geckguy and others added 2 commits

June 13, 2023 02:26


          Update src/py/reactpy/reactpy/backend/default.py

9028c58

Co-authored-by: Ryan Morshead <ryan.morshead@gmail.com>


          Improve readability

6570a61

rmorshea reviewed

View reviewed changes

src/py/reactpy/reactpy/backend/default.py Outdated Show resolved Hide resolved


          Update src/py/reactpy/reactpy/backend/default.py

Contributor Author

geckguy commented Jun 13, 2023

why are some checks still failing?

Smit-Parmar reviewed

View reviewed changes

src/py/reactpy/reactpy/backend/default.py Outdated Show resolved Hide resolved


          make text bold

f25dc26

Smit-Parmar approved these changes

View reviewed changes

rmorshea approved these changes

View reviewed changes

rmorshea merged commit 8120ddc into reactive-python:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet