Skip to content

Refactoring for v5.2 #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
cfde802
Use `ensure_async` instead of `database_sync_to_async`
Archmonger Dec 11, 2024
1070b80
Handle all pyright warnings
Archmonger Dec 11, 2024
8ec20b7
Add CI workflow for pyright
Archmonger Dec 11, 2024
3711803
Grouo pyscript related code into module
Archmonger Dec 11, 2024
1ee2799
cached_static_contents -> cached_static_file
Archmonger Dec 11, 2024
e7d1764
vdom_or_component_to_string -> reactpy_to_string
Archmonger Dec 11, 2024
67966e2
strtobool -> str_to_bool
Archmonger Dec 11, 2024
8ab7f23
Fix borked type hints
Archmonger Dec 11, 2024
5d2dd0e
More generic function for form field conversion
Archmonger Dec 11, 2024
16f076d
validate_form_args function
Archmonger Dec 11, 2024
1a4fcaa
Refactor javascript
Archmonger Dec 11, 2024
90a6308
rename `clean` module to `tasks`
Archmonger Dec 11, 2024
0b593a5
Fix one instance of test flakiness
Archmonger Dec 11, 2024
0cd8218
Add test retries
Archmonger Dec 12, 2024
1e1bf36
hatch fmt
Archmonger Dec 12, 2024
2a1fa06
rename hook async_render -> render_view
Archmonger Dec 12, 2024
c8d6cf9
Turn navigate_to_page into a decorator
Archmonger Dec 12, 2024
9f9f99d
Refactor PlaywrightTestCase
Archmonger Dec 13, 2024
c5f8d68
Move flaky marker to sync form test
Archmonger Dec 13, 2024
fa13697
Apparently I forgot PyScript FFI docs
Archmonger Dec 14, 2024
a607daa
Test performance optimization: Use same class for alll component tests
Archmonger Dec 18, 2024
4165542
Fix typo
Archmonger Dec 18, 2024
f99e585
Increase prerender sleepy time
Archmonger Dec 18, 2024
6238383
more sleepy time
Archmonger Dec 19, 2024
207cf19
variable name and docstring cleanup
Archmonger Dec 19, 2024
08fd30c
Add changelog
Archmonger Dec 19, 2024
39b29fc
prevent test pages from jumping around
Archmonger Dec 19, 2024
9d1c65f
More sleepy time on github
Archmonger Dec 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move flaky marker to sync form test
  • Loading branch information
Archmonger committed Dec 13, 2024
commit c5f8d68672eb4ec5c182fbd41e192809e383a1fc
3 changes: 0 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,6 @@ extra-dependencies = [

]
matrix-name-format = "{variable}-{value}"
# TODO: Remove the `retries` value once we fix flakiness of `test_sync_form_events`
# https://github.com/reactive-python/reactpy-django/issues/272
retries = 5

# Django 4.2
[[tool.hatch.envs.hatch-test.matrix]]
Expand Down
3 changes: 3 additions & 0 deletions tests/test_app/tests/test_components.py
Original file line number Diff line number Diff line change
Expand Up @@ -799,6 +799,9 @@ def test_model_form(self):
finally:
os.environ.pop("DJANGO_ALLOW_ASYNC_UNSAFE")

# TODO: Remove the `reruns` value once we fix flakiness of `test_sync_form_events`
# https://github.com/reactive-python/reactpy-django/issues/272
@pytest.mark.flaky(reruns=5)
@navigate_to_page("/form/sync_event/")
def test_sync_form_events(self):
self.page.wait_for_selector("form")
Expand Down