Skip to content

Add Django CSS/JS de-duplication #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Add Django CSS/JS de-duplication #226

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5e8e593
functional only-once implementation
Archmonger Feb 6, 2024
fdf399e
cleanup
Archmonger Feb 6, 2024
1225951
css test component
Archmonger Feb 6, 2024
6cd6154
Set default to false
Archmonger Feb 6, 2024
767aeea
rename only_once to allow_duplicates
Archmonger Feb 10, 2024
dcd6a55
Only configure the scope if using `allow_duplicates=false`
Archmonger Feb 12, 2024
57b1950
DRY static file loading
Archmonger Feb 12, 2024
726e244
minor docs syntax highlighting
Archmonger Feb 18, 2024
f8cb34c
docstrings
Archmonger Feb 18, 2024
6f64d46
bump deprecated workflows
Archmonger Feb 18, 2024
acf7e6d
functional test components
Archmonger Feb 18, 2024
b5bfe4b
add changelog
Archmonger Feb 19, 2024
d04fdab
test stubs
Archmonger Feb 19, 2024
d5ff8fa
Redo how we set up lists for the test
Archmonger Feb 19, 2024
999a469
try using discrete mount/unmount managers
Archmonger Feb 19, 2024
d5b16dd
Make sure test elements always have keys
Archmonger Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only configure the scope if using allow_duplicates=false
  • Loading branch information
@Archmonger
Archmonger committed Feb 12, 2024
commit dcd6a55d859a815100ed5eff2d7abf2a2a78d8f7
16 changes: 12 additions & 4 deletions src/reactpy_django/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,12 +259,16 @@ def _view_to_iframe(
def _django_css(static_path: str, allow_duplicates: bool):
scope = use_scope()
ownership_uuid = hooks.use_memo(lambda: uuid4())
scope.setdefault("reactpy", {}).setdefault("css", {})
scope["reactpy"]["css"].setdefault(static_path, ownership_uuid)

# Configure the scope to track the file
if not allow_duplicates:
scope.setdefault("reactpy", {}).setdefault("css", {})
scope["reactpy"]["css"].setdefault(static_path, ownership_uuid)

# Load the file if no other component has loaded it
@hooks.use_effect(dependencies=None)
async def duplicate_manager():
"""Note: This hook runs on every render. This is intentional."""
if allow_duplicates:
return

Expand All @@ -287,12 +291,16 @@ def unmount():
def _django_js(static_path: str, allow_duplicates: bool):
scope = use_scope()
ownership_uuid = hooks.use_memo(lambda: uuid4())
scope.setdefault("reactpy", {}).setdefault("js", {})
scope["reactpy"]["js"].setdefault(static_path, ownership_uuid)

# Configure the scope to track the file
if not allow_duplicates:
scope.setdefault("reactpy", {}).setdefault("js", {})
scope["reactpy"]["js"].setdefault(static_path, ownership_uuid)

# Load the file if no other component has loaded it
@hooks.use_effect(dependencies=None)
async def duplicate_manager():
"""Note: This hook runs on every render. This is intentional."""
if allow_duplicates:
return

Expand Down