bot.js: enable autoRenick by default #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the client reconnects to IRC after a timeout, the bot nickname is often still in use (the client receives an `err_nicknameinuse` message), and the bot is given an alternate nickname by the server. In this case, it is almost always desirable to try to change the nickname back to the configured nickname, so we enable `autoRenick` by default. NOTE: `autoRenick` can be disabled by specifying `autoRenick: false` in `ircOptions` in the discord-irc configuration file, or the behavior can be modified with the `renickCount` and `renickDelay` options. See the node-irc documentation for more details.
|
I agree that this is a good idea, since users of this bot probably expect it to retain the nickname they gave it. It's not enabled in the upstream library by default, but makes sense (at least in my mind) for it to be enabled in Assuming @ekmartin is okay with it I think this should merge. Thanks! |
Throne3d
approved these changes
Sep 17, 2017
|
Agreed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the client reconnects to IRC after a timeout, the bot nickname
is often still in use (the client receives an
err_nicknameinusemessage), and the bot is given an alternate nickname by the server.
In this case, it is almost always desirable to try to change the
nickname back to the configured nickname, so we enable
autoRenickby default.
NOTE:
autoRenickcan be disabled by specifyingautoRenick: falsein
ircOptionsin the discord-irc configuration file, or thebehavior can be modified with the
renickCountandrenickDelayoptions. See the node-irc documentation for more details.