Move from irc 0.5.2 to irc-upd 0.6.1 #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The irc module does not appear to be very actively maintained, and has quite a few issues causing issues in this project itself. This fork, maintained by me, has a few fixes to some major issues already. Changelogs: - v0.6.0 - https://github.com/Throne3d/node-irc/releases/tag/v0.6.0 - v0.6.1 - https://github.com/Throne3d/node-irc/releases/tag/v0.6.1 Should fix reactiflux#199, reactiflux#200, as well as some issues not previously noted (crash if unbanning a user who is not banned, crash in circumstances with a poor internet connection). It may also allow us to remove our workaround for the quit and nick events having all channels in the associated array.
|
Good idea! |
ekmartin
approved these changes
Jul 1, 2017
|
I've added you as an owner of the npm package - wanna try publishing a release for this, #256, #257 and the Doppins dependency upgrades? The process is basically:
|
|
Sure! I'll get to doing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ircmodule does not appear to be very actively maintained, and has quite a few issues causing issues in this project itself.This fork, maintained by me, has a few fixes to some major issues already.
Changelogs:
Should fix #199, #200, as well as some issues not previously noted (crash if unbanning a user who is not banned, crash in circumstances with a poor internet connection).
It may also allow us to remove our workaround for the quit and nick events having all channels in the associated array.
As far as I can tell this breaks no tests (and in fact I added a few to the
irc-updpackage, since it seems to be lacking) and should (if you trust it to be better maintained than the current one) be a good improvement to the project.