check if an user is present in the channel for nickchange #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekmartin
reviewed
May 16, 2017
| this.channelUsers[channel].delete(oldNick); | ||
| this.channelUsers[channel].add(newNick); | ||
| this.sendExactToDiscord(channel, `*${oldNick}* is now known as ${newNick}`); | ||
| } | ||
| } else { | ||
| logger.warn(`No channelUsers found for ${channel} when ${oldNick} changed.`); |
There was a problem hiding this comment.
To be honest I don't think we really need the logger warning here, so maybe just fold the two ifs into one and do if (this.channelUsers[channel] && this.channelUsers[channel].has(oldNick)) {?
There was a problem hiding this comment.
Or what do you think @Throne3d?
There was a problem hiding this comment.
The logger warning probably isn't necessary – it was mostly to get around the issue with lowercasing channel names, in the other events. I don't think it's harmful to leave it though.
There was a problem hiding this comment.
Eh, I guess not. Just a bit cleaner code, but it'll do.
ekmartin
approved these changes
May 16, 2017
|
no worries, thanks for the fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i only check if the channel has been tracked, not if the user was present in the channel.
i fu**ed up, i'm sorry :D