Avoid self-message highlights on IRC #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have cleaned this pull request up. It now uses zero width space characters which seem to work in all clients so far. |
ekmartin
requested changes
Mar 1, 2017
|
|
||
| // Join the display name with double "bold" formatting characters | ||
| // to prevent unintentional highlights on the IRC side | ||
| displayUsername = displayUsername.split('').join('\u200d'); |
There was a problem hiding this comment.
Maybe merge this with line 164? I.e. let displayUsername = nickname.split('').join('\u200d');
There was a problem hiding this comment.
I think this is more explicit since it doesn't combine the operation with getting the name from another variable (and allows the comment to stand on its own), but I can do it.
test/bot.test.js
Outdated
| @@ -98,7 +98,7 @@ describe('Bot', function () { | |||
| }; | |||
|
|
|||
| bot.sendToIRC(message); | |||
| const expected = `<${message.author.username}> ${text}`; | |||
| const expected = `<${message.author.username.split('').join('\u200d')}> ${text}`; | |||
There was a problem hiding this comment.
could add a simple helper function somewhere towards the top of the file that does the splitting?
i.e.
const escapeUsername = username => username.split('').join('\u200d');
|
Tested with Weechat, seems to be working well. Thanks! Released in version 2.2.0. |
This was referenced Mar 12, 2017
Closed
meooow42
pushed a commit
to Reddit-R4R/discord-irc
that referenced
this pull request
Jun 14, 2017
Avoid self-message highlights on IRC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user connected to both Discord and IRC speaks on Discord, they will likely get unwanted highlights in their IRC client. This is a fix which I believe is standard practice. By putting a zero width space character between each letter of the display name, we ensure IRC clients do not detect the name and highlight on it.
The other line in the commit is a fix where the wrong variable was being used.