fix(themes): use fitting desktop colors for remaining themes #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/arturbien/react95/BNcdUSVhFc2gQQZmkXVyPkBERQhB |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6e2ced1:
|
Use a fitting hand-picked desktop background color that matches the existing colors and spirit of the theme. For theSixtiesUSA and travel, the two themes that originate from the Windows 98 Plus! pack, colors based on the original wallpaper were chosen. The original themes themselves specify full black as the desktop background, supposedly with the assumption that the included wallpaper would be used, making the background color irrelevant. coldGray and lilacRoseDark appear similar to themes published at Mochinet (https://www.mochinet.com/Themes/), but they do not appear to be the same themes. New colors were chosen instead of taking from the Mochinet themes since the Mochinet themes are low contrast, whereas the React95 themes are not.
tpenguinltg
force-pushed
the
fix/other-desktop-background
branch
from
de6a52d to
6e2ced1
Compare
|
@tpenguinltg awesome work as always.🚀 |
|
🎉 This PR is included in version 3.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the work of #238. The remaining themes now use a hand-picked desktop background color that matches the existing colors and spirit of the theme.
For
theSixtiesUSAandtravel, the two themes that originate from the Windows 98 Plus! pack, colors based on the original wallpaper were chosen. The original themes themselves specify full black as the desktop background, supposedly with the assumption that the included wallpaper would be used, making the background color irrelevant.coldGrayandlilacRoseDarkappear similar to themes published at Mochinet, but they do not appear to be the same themes. New colors were chosen instead of taking from the Mochinet themes since the Mochinet themes are low contrast, whereas the React95 themes are not.Closes #223