Feature/menu checkbox and radio #101
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8eb8238:
|
src/components/Checkbox/Checkbox.js
Outdated
| const CheckboxComponent = | ||
| variant === 'flat' ? StyledFlatCheckbox : StyledCheckbox; | ||
|
|
||
| const CheckboxComponent = { |
There was a problem hiding this comment.
What do you think about declaring this CheckboxComponent outside of render? Since the components are static I don't see a need to declare them on every render, what do you think?
Just to be clear, my idea is to declare the checkbox components outside of render and only instantiate the component that'll be used inside of render, like:
// outside of render
const CheckboxComponents = {
flat: StyledFlatCheckbox,
default: StyledCheckbox,
menu: StyledMenuCheckbox
}
// inside of render
const CheckboxVariant = CheckboxComponents[variant]Does that make sense for you?
src/components/Radio/Radio.js
Outdated
| const CheckboxComponent = | ||
| variant === 'flat' ? StyledFlatCheckbox : StyledCheckbox; | ||
|
|
||
| const CheckboxComponent = { |
There was a problem hiding this comment.
Same thing for declaring this outside of render goes here.
|
🎉 This PR is included in version 3.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
closes #92