feat(style) - Add media query syntax support#57439
Draft
intergalacticspacehighway wants to merge 4 commits into
Draft
feat(style) - Add media query syntax support#57439intergalacticspacehighway wants to merge 4 commits into
intergalacticspacehighway wants to merge 4 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Adding more details in RFC)
Summary:
Adds native media query support to stylesheet. The majority of changes are in the shared cpp layer. It relies on scheduler commit hook to resolve the media query styles. Native just adds a color scheme listener. It borrows the stylex's syntax and naming conventions for media query styles (conditional styles). RSD also uses similar syntax. It also works for RN since it makes the ordering intuitive when flattening.
The viewport size (size that is used by media query) is derived from the surface size in which RN app is hosted.
Changelog:
[GENERAL] [ADDED] - Stylesheet media query support
Test Plan:
Tried to cover majority of paths. Added unit and fantom tests.
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-07-06.at.13.06.47.mov