Persist Change Bundle Location host setting#57425
Open
Phecda wants to merge 1 commit into
Open
Conversation
Change Bundle Location updates PackagerConnectionSettings.debugServerHost, but the setter only updated the in-memory cached host. After the app process restarted, PackagerConnectionSettings read debug_http_host from default SharedPreferences and fell back to the previous value. Persist the selected host to the same debug_http_host preference used by DevSettingsActivity so both entry points share the same storage path.
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
Abbondanzo
requested changes
Jul 6, 2026
Abbondanzo
left a comment
Abbondanzo
left a comment
Contributor
There was a problem hiding this comment.
This is actually leftovers from a migration away from persisting the bundle location to disk (#54139). The shared preferences read is only there for legacy reasons, but given that iOS is still writing to disk I think it's fine to reintroduce such a change. Left a few review comments to fix up first
| } | ||
| set(host) { | ||
| if (host.isEmpty()) { | ||
| _cachedOrOverrideHost = null |
Contributor
There was a problem hiding this comment.
Nit: rather than storing a null string, can you have this remove the string altogether?
| } | ||
|
|
||
| public open fun resetDebugServerHost() { | ||
| _cachedOrOverrideHost = null |
Contributor
There was a problem hiding this comment.
The preferences should be cleared here too, but the constructor would have to updated to not call this method and blast this away each time
Suggested change
| preferences.edit().remove(PREFS_DEBUG_SERVER_HOST_KEY).apply() | |
| _cachedOrOverrideHost = null |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Persist
Change Bundle Locationupdates to the samedebug_http_hostpreference used by the Android Dev Settings screen.Previously,
Change Bundle Locationonly updated the in-memoryPackagerConnectionSettingshost override. After killing and restarting the app process, the host was read again fromSharedPreferences, so the change was lost.Changelog:
[ANDROID] [FIXED] - Persist Change Bundle Location debug server host changes
Test Plan:
Verified with RNTester
debugOptimizedon Android:Change Bundle Location.