documented NativeMethodsMixin - #3238
Closed
corbt wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
Nice! Thanks a lot! @facebook-github-bot shipit |
Contributor
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/678035415658680/int_phab to review. |
Contributor
|
Merging this internally, made some minor adjustments. |
Contributor
There was a problem hiding this comment.
I removed this empty line to make this render correctly: http://imgur.com/IDu30rX
To test rendering locally:
$ cd website
$ npm start
...
Open http://localhost:8079/react-native/index.html
Contributor
Author
There was a problem hiding this comment.
Huh yeah I had tested it with local rendering using the instructions you mentioned, and it seemed to be formatted ok on my machine even with that newline. But whatever, glad it works now!
ghost
closed this
in
MattFoley
pushed a commit
to skillz/react-native
that referenced
this pull request
Nov 9, 2015
Summary: This is related to the discussion in react#3155. I've documented the methods in this mixin, and pointed to other appropriate documentation where necessary as well. I didn't end up adding any examples. I wanted to add a `focus()`/`blur()` example to the UIExplorer app, but the app seems to be broken on master at the moment (`Requiring unknown module "event-target-shim"`) and I didn't bother trying to fix it. I think the last thing necessary for making the usage of these methods clear is an example of calling one or more of them on a `ref` or view captured in some other way. However, `setNativeProps` is well documented in the "Direct Manipulation" guide, which I link to from this page, so by extension it should be possible to figure out the functionality of the other methods. cc @mkonicek @astreet Closes react#3238 Reviewed By: @svcscm Differential Revision: D2517187 Pulled By: @mkonicek fb-gh-sync-id: 4e68b2bc44ace83f06ae2e364ca0c23a7c461b20
Crash--
pushed a commit
to Crash--/react-native
that referenced
this pull request
Dec 24, 2015
Summary: This is related to the discussion in react#3155. I've documented the methods in this mixin, and pointed to other appropriate documentation where necessary as well. I didn't end up adding any examples. I wanted to add a `focus()`/`blur()` example to the UIExplorer app, but the app seems to be broken on master at the moment (`Requiring unknown module "event-target-shim"`) and I didn't bother trying to fix it. I think the last thing necessary for making the usage of these methods clear is an example of calling one or more of them on a `ref` or view captured in some other way. However, `setNativeProps` is well documented in the "Direct Manipulation" guide, which I link to from this page, so by extension it should be possible to figure out the functionality of the other methods. cc @mkonicek @astreet Closes react#3238 Reviewed By: @svcscm Differential Revision: D2517187 Pulled By: @mkonicek fb-gh-sync-id: 4e68b2bc44ace83f06ae2e364ca0c23a7c461b20
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to the discussion in #3155.
I've documented the methods in this mixin, and pointed to other appropriate documentation where necessary as well.
I didn't end up adding any examples. I wanted to add a
focus()/blur()example to the UIExplorer app, but the app seems to be broken on master at the moment (Requiring unknown module "event-target-shim") and I didn't bother trying to fix it. I think the last thing necessary for making the usage of these methods clear is an example of calling one or more of them on arefor view captured in some other way. However,setNativePropsis well documented in the "Direct Manipulation" guide, which I link to from this page, so by extension it should be possible to figure out the functionality of the other methods.cc @mkonicek @astreet