enable es6 module syntax - #3175
Merged
Merged
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
@facebook-github-bot shipit |
Contributor
|
Thanks :) |
Contributor
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1632187277035647/int_phab to review. |
Contributor
Author
|
#1940 should be merged as well. |
Contributor
|
@corbt can you rebase this on top of master and update your git commit title/message just to mention the docs change. Then I can merge it for you. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
Contributor
Author
|
@ide done. |
Contributor
|
Thanks! |
|
@ide I have a question when using offline bundle.First start app, the top appears ' loading from pre-bundle file',How can I remove it or don't let it show |
MattFoley
pushed a commit
to skillz/react-native
that referenced
this pull request
Nov 9, 2015
Summary: This is an updated copy of react#1993, which was approved by @vjeux but hasn't been rebased. It whitelists the es6 module syntax and updates the JS Environment docs to match. cc @ide @hkjorgensenCloses react#3175 Reviewed By: @svcscm Differential Revision: D2498360 Pulled By: @vjeux
Crash--
pushed a commit
to Crash--/react-native
that referenced
this pull request
Dec 24, 2015
Summary: This is an updated copy of react#1993, which was approved by @vjeux but hasn't been rebased. It whitelists the es6 module syntax and updates the JS Environment docs to match. cc @ide @hkjorgensenCloses react#3175 Reviewed By: @svcscm Differential Revision: D2498360 Pulled By: @vjeux
cpojer
pushed a commit
to react/metro
that referenced
this pull request
Jan 26, 2017
Summary: This is an updated copy of #1993, which was approved by @vjeux but hasn't been rebased. It whitelists the es6 module syntax and updates the JS Environment docs to match. cc @ide @hkjorgensenCloses react/react-native#3175 Reviewed By: @svcscm Differential Revision: D2498360 Pulled By: @vjeux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated copy of #1993, which was approved by @vjeux but hasn't been rebased. It whitelists the es6 module syntax and updates the JS Environment docs to match. cc @ide @hkjorgensen