Always emit indexed source maps; remove unstable_allowIndexMap (#1764)#1764
Open
robhogan wants to merge 2 commits into
Open
Always emit indexed source maps; remove unstable_allowIndexMap (#1764)#1764robhogan wants to merge 2 commits into
robhogan wants to merge 2 commits into
Conversation
…ults to `true` Differential Revision: D110759649
d7879c6 to
30ec906
Compare
30ec906 to
d7879c6
Compare
robhogan
added a commit
that referenced
this pull request
Jul 6, 2026
Summary: Pull Request resolved: #1764 Index maps are now safe to emit unconditionally, so this removes the choice, updates snapshots, and cleans up dead code. Note that `unstable_allowIndexMap` was only recently added and has never been in an published release, so there's no danger removing it. The observable change that Metro will now emit index maps has a changelog entry in the previous diff that flipped the defaults. Changelog: Internal` Reviewed By: motiz88 Differential Revision: D110757150
d7879c6 to
d3a025f
Compare
Contributor
|
@robhogan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110757150. |
Summary: Pull Request resolved: #1764 Index maps are now safe to emit unconditionally, so this removes the choice, updates snapshots, and cleans up dead code. Note that `unstable_allowIndexMap` was only recently added and has never been in an published release, so there's no danger removing it. The observable change that Metro will now emit index maps has a changelog entry in the previous diff that flipped the defaults. Changelog: Internal` Reviewed By: motiz88 Differential Revision: D110757150
d3a025f to
a035fe7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Index maps are now safe to emit unconditionally, so this removes the choice, updates snapshots, and cleans up dead code.
Note that
unstable_allowIndexMapwas only recently added and has never been in an published release, so there's no danger removing it.The observable change that Metro will now emit index maps has a changelog entry in the previous diff that flipped the defaults.
Changelog: Internal`
Reviewed By: motiz88
Differential Revision: D110757150