Repository navigation
react-scripts test (or Jest) is reporting exit code 0 on test failures #7180
Description
Is this a bug report?
Possibly
Did you try recovering your dependencies?
Yes
Environment
System:
OS: macOS High Sierra 10.13.6
CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Binaries:
Node: 8.12.0 - ~/.nvm/versions/node/v8.12.0/bin/node
Yarn: 1.10.1 - /usr/local/bin/yarn
npm: 6.4.1 - ~/.nvm/versions/node/v8.12.0/bin/npm
Browsers:
Chrome: 75.0.3770.80
Firefox: 66.0.2
Safari: 12.1
npmPackages:
react: ^16.6.3 => 16.6.3
react-dom: ^16.6.3 => 16.6.3
react-scripts: 2.1.8 => 2.1.8
npmGlobalPackages:
create-react-app: Not Found
Steps to Reproduce
- Create a CRA project with tests
- Create a bash script that encapsulates the
react-scripts testcommand execution - Output the exit code result from within that wrapping bash script
Expected Behavior
I expect the exit code to be non-zero when tests fail
Actual Behavior
react-scripts test is reporting a 0 exit code
Reproducible Demo
None yet
Activity
bugzpodder commentedon Jun 6, 2019
You can try setting CI=true to get a non-zero exit code.
heyimalex commentedon Jun 6, 2019
Duplicate of #7026 I think. Last time I checked we're doing everything right, but jest doesn't return the appropriate error code.
thedanchez commentedon Jun 6, 2019
Setting the
CIenv variable works but the usage of that for local test runs doesn't seem right to me. We also lose the pretty output.Been digging around for the past couple of hours and found that adding
--bailin the CLI works as well.[-]react-scripts test is not reporting non-zero exit code on test failures (when running inside a bash script)[/-][+]react-scripts test (or Jest) is reporting exit code 0 on test failures[/+]goranefbl commentedon Jun 10, 2019
I think its the same problem as #6944
I have a Husky configured and without CI env, even though tests are failing, Husky is not stopping commits from going through. Adding of CI works, but as @thedanchez pointed out, we are losing pretty output.
Update:
Seems that --bail keeps the pretty output.
silverwind commentedon Jun 27, 2019
Confirmed, steps to reproduce:
bugzpodder commentedon Jun 27, 2019
I think add --bail works as others pointed out
silverwind commentedon Jun 27, 2019
Imho, a proper exit code should be set by default and not only with obscure arguments like
--bail.bugzpodder commentedon Jun 27, 2019
Agreed, PRs welcome!
mAAdhaTTah commentedon Jul 19, 2019
Also
--bailwill stop running tests on the first error, rather than running the full test suite then erroring.Add explicit check for --watchAll=false
Add explicit check for --watchAll=false (#7433)
Add explicit check for --watchAll=false (react#7433)
Update cra fork (#2)
Feature/customized webpack plugin integration (#2)
Add explicit check for --watchAll=false (react#7433)