Support jest globalSetup #4393

Activity

1. Stupidism commented on May 3, 2018

   

   Stupidism

   on May 3, 2018

   More actions

   @DuskLoop I think react-app-rewired can help you modifying jest config without ejecting
2. gaearon commented on May 3, 2018

   

   gaearon

   on May 3, 2018

   Contributor

   More actions

   Maybe it would be sufficient to use a global flag in src/setupTest.js?

   if (!global.initializedTests) {
     // do something
     global.initializedTests = true;
   }

   I'm not 100% sure but I think global variables should persist between tests.
3. gaearon

   added

   tag: new feature

   on May 3, 2018
4. DuskLoop commented on May 4, 2018

   

   DuskLoop

   on May 4, 2018

   Author

   More actions

   @gaearon global does not seem to persist between test files.

   This code:

   if (!global.initializedTests) {
     console.log("doing something");
     global.initializedTests = true;
   }
   

   prints for every test file and no difference in performance
5. DuskLoop commented on May 4, 2018

   

   DuskLoop

   on May 4, 2018

   Author

   More actions

   @Stupidism I tried running tests with react-app-rewired only to find out that react-scripts currently uses jest 20.0.4, the globalSetup option is supported in jest 22.

   Looks like react-scripts is on it's way to update their jest dependency though, the next branch uses version 22.4.1.
6. Brian-McBride commented on Oct 1, 2018

   

   Brian-McBride

   on Oct 1, 2018

   More actions

   This is an easy change in one file: https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/scripts/utils/createJestConfig.js

   Current:

     const supportedKeys = [
       'collectCoverageFrom',
       'coverageReporters',
       'coverageThreshold',
       'resetMocks',
       'resetModules',
       'snapshotSerializers',
       'watchPathIgnorePatterns',
     ];
   

   Changed:

     const supportedKeys = [
       'collectCoverageFrom',
       'coverageReporters',
       'coverageThreshold',
       'globalSetup',
       'globalTeardown',
       'resetMocks',
       'resetModules',
       'snapshotSerializers',
       'watchPathIgnorePatterns',
     ];
   

   One the keys are allowed to pass through, you can just specify these in your package.json jest:{} entry (or wherever).
7. gaearon commented on Oct 1, 2018

   

   gaearon

   on Oct 1, 2018

   Contributor

   More actions

   That sounds fine to support out of the box. I'll add it.
8. gaearon

   closed this as completedin #5218on Oct 1, 2018
9. pakaplace commented on Nov 6, 2018

   

   pakaplace

   on Nov 6, 2018

   More actions

   @gaearon , curious as to why certain Jest config options are supported and others are not? I want to use the Jest preset config option, in order to use the jest-puppeteer module with my create-react-app. Could you add it as a supportedKey?

   👍React with 👍1Reacted by Konrad
10. patricklafrance commented on Nov 7, 2018

    

    patricklafrance

    on Nov 7, 2018

    Last edited by patricklafrance

    More actions

    @pakaplace if you customize your CRA with craco you could do it.

    Here's a sample craco.config.js file:

    module.exports = {
        jest: {
            configure: {
                 preset: "jest-puppeteer"
            }
        }
    };

    Hope this helps!
11. lock

    locked and limited conversation to collaborators on Jan 9, 2019