Skip to content

Add popover z index property. #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add popover z index property. #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/components/Popover/Popover.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,16 @@ export const Popover = React.forwardRef((props, ref) => {
placementStyle,
popoverTargetId,
portalId,
zIndex,
...restProps
} = props;

const placementStyleObject = placementStyle ? cleanPlacementStyle(placementStyle) : {};
const style = zIndex !== undefined ? {
...placementStyleObject,
zIndex,
} : placementStyleObject;

const PopoverEl = (
<>
{/**
Expand All @@ -43,7 +50,7 @@ export const Popover = React.forwardRef((props, ref) => {
getRootAlignmentClassName(placement, styles),
)}
ref={ref}
style={placementStyle ? cleanPlacementStyle(placementStyle) : undefined}
style={style}
>
{children}
<span className={styles.arrow} />
Expand All @@ -63,6 +70,7 @@ Popover.defaultProps = {
placementStyle: undefined,
popoverTargetId: undefined,
portalId: undefined,
zIndex: undefined,
};

Popover.propTypes = {
Expand Down Expand Up @@ -116,6 +124,10 @@ Popover.propTypes = {
* If set, popover is rendered in the React Portal with that ID.
*/
portalId: PropTypes.string,
/**
* Z-Index of the popover.
*/
zIndex: PropTypes.number,
};

export const PopoverWithGlobalProps = withGlobalProps(Popover, 'Popover');
Expand Down