Refactoring/transform typescript #602
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
src/components/Grid/_helpers/generateResponsiveCustomProperties.ts
Outdated
Show resolved
Hide resolved
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
reviewed
Apr 25, 2025
atmelmicro
requested changes
Apr 25, 2025
lukasbriza
force-pushed
the
refactoring/transform-typescript
branch
from
31fa9b7 to
c1a3856
Compare
I introduced Playwright Component Testing as replacement for Jest and RTL. Those tests must be run within `playwright` docker container with pre-installed browsers to ensure uniform testing environment. `.env.playwright` is created using `postinstall` script to follow zero-config setup. `.env.playwright` can be used to tweak parameters for local development if needed. `.env` newly contains Playwright related configuration for Docker. Currently, only tests for `Alert` and `Button` components are migrated to Playwright CT as this commit is supposed to be proof-of-concept. Rest should be migrated in later pull request. All visual tests use prop tests concept we already have for Jest to simplify testing and to make it DRY. `mixPropTests()` is introduced to mix those to create combinations to be tested. New Github workflow is introduced to test only Playwright as it can be time exhausting. Further improvements are expected to be make in the future.
Transform Playwright related files to Typescript and introduce temporary configuration files `.eslintrc-ts`, `jest.config-ts.js` and `tsconfig.json` that must be removed when whole package is transformed into Playwright. Due to missing TypeScript support in the rest of the package, `*.spec.tsx` and `*.story.tsx` file do not have complete types and might not be compatible with strict type checking that should be introduced in #394. The reason for such change is parallel work on transformation to TypeScript and on Playwright tests.
lukasbriza
force-pushed
the
refactoring/transform-typescript
branch
from
c1a3856 to
f5daa5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to maintain the existing logic; however, for about two components, I had to implement a few additional things due to TypeScript. Please review and let me know if this works for you.