Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate styles of Alert, Button and Card color variants using collections #563

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

adamkudrna
Copy link
Member

No description provided.

@adamkudrna adamkudrna changed the base branch from master to feature/badge-theming-using-collections August 31, 2024 21:32
@adamkudrna adamkudrna added this to the v1.0.0 milestone Sep 2, 2024
Copy link
Contributor

@bedrich-schindler bedrich-schindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks terrific! Hard to review, but I hope it is all right.

@adamkudrna
Copy link
Member Author

Hard to review

From my experience, adding unit tests for Sass mixins and functions helps. We use the sass-true library for unit tests in Spirit. If we agree, I'll be happy to add it here (and in the downstream projects).

@adamkudrna adamkudrna force-pushed the feature/badge-theming-using-collections branch from c272c09 to 34b7052 Compare September 11, 2024 15:34
Base automatically changed from feature/badge-theming-using-collections to master September 11, 2024 15:44
@adamkudrna adamkudrna merged commit c104d82 into master Sep 11, 2024
11 checks passed
@adamkudrna adamkudrna deleted the refactor/use-color-collections branch September 11, 2024 15:49
@adamkudrna adamkudrna mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants