Improve the design of Table with sorting buttons

react-ui-org · Feb 22, 2023 · d4ea296 · d4ea296
1 parent c0d4582
commit d4ea296
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/src/lib/components/Table/_components/TableCell.scss b/src/lib/components/Table/_components/TableCell.scss
@@ -14,12 +14,13 @@
     border-bottom-width: 2px;
 }
 
+.tableHeadCellLayout {
+    display: flex;
+    gap: settings.$cell-padding-x;
+    align-items: center;
+}
+
 .isTableCellSortingActive,
 .isTableHeadCellSortingActive {
     background-color: settings.$sorted-background-color;
 }
-
-.sortButton {
-    display: inline-block;
-    margin-right: settings.$cell-padding-x;
-}
diff --git a/src/lib/components/Table/_components/TableHeaderCell/TableHeaderCell.jsx b/src/lib/components/Table/_components/TableHeaderCell/TableHeaderCell.jsx
@@ -16,23 +16,26 @@ export const TableHeaderCell = ({
       className={isSortingActive ? styles.isTableHeadCellSortingActive : styles.tableHeadCell}
       id={id}
     >
-      {sort && column.isSortable && (
-        <div className={styles.sortButton}>
+      <span className={styles.tableHeadCellLayout}>
+        {sort && column.isSortable && (
           <Button
+            aria-pressed={isSortingActive}
             beforeLabel={
               sortDirection === 'asc'
                 ? sort.ascendingIcon
                 : sort.descendingIcon
             }
+            color={isSortingActive ? 'selected' : 'secondary'}
             id={id && `${id}__sortButton`}
             label={sortDirection}
             labelVisibility="none"
             onClick={() => sort.onClick(column.name, sortDirection)}
             priority="flat"
+            size="small"
           />
-        </div>
-      )}
-      {column.label}
+        )}
+        {column.label}
+      </span>
     </th>
   );
 };