Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

Fix renderPager undefined override #70

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Fix renderPager undefined override #70

merged 1 commit into from
Nov 30, 2018

Conversation

mmtootmm
Copy link
Contributor

Motivation

react-native-tab-view provides some pager alternatives like PagerExperimental but we can't use it with react-navigation-tabs because it always overrides renderPager prop with undefined.

Test plan

When useNativeDriver={true}, built-in MaterialTopTabBar not working because color style prop not supported by native animation.

createMaterialTopTabNavigator({
  ...
}, {
  tabBarComponent: CustomTabBarComponent,
  renderPager: props => <PagerExperimental {...props} {GestureHandler} userNativeDriver={true} />
})

@brentvatne brentvatne merged commit 0426c46 into react-navigation:master Nov 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants