[Flow] Some updates, mostly from flow-typed #3682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove `NavigationComponent` from `NavigationScreenRouteConfig`. The only context `NavigationScreenRouteConfig` is used in is as an intersection with an object, and as such the only relevant portions of `NavigationScreenRouteConfig` are the object parts. 2. Add static `HEIGHT` variable to `Header` type. 3. In `NavigationContainerProps`, make `onNavigationStateChange` property value nullable. PS: if in the future you guys would prefer that I separate these sort of PRs into their constituent parts, let me know.
|
NavigationPlayground for 7875903 has been deployed. |
|
NavigationPlayground for 5fa236e has been deployed. |
Ashoat
added a commit
that referenced
this pull request
Mar 7, 2018
1. Remove `NavigationComponent` from `NavigationScreenRouteConfig`. The only context `NavigationScreenRouteConfig` is used in is as an intersection with an object, and as such the only relevant portions of `NavigationScreenRouteConfig` are the object parts. 2. Add static `HEIGHT` variable to `Header` type. 3. In `NavigationContainerProps`, make `onNavigationStateChange` property value nullable. PS: if in the future you guys would prefer that I separate these sort of PRs into their constituent parts, let me know.
sourcecode911
pushed a commit
to sourcecode911/react-navigation
that referenced
this pull request
Mar 9, 2020
1. Remove `NavigationComponent` from `NavigationScreenRouteConfig`. The only context `NavigationScreenRouteConfig` is used in is as an intersection with an object, and as such the only relevant portions of `NavigationScreenRouteConfig` are the object parts. 2. Add static `HEIGHT` variable to `Header` type. 3. In `NavigationContainerProps`, make `onNavigationStateChange` property value nullable. PS: if in the future you guys would prefer that I separate these sort of PRs into their constituent parts, let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NavigationComponentfromNavigationScreenRouteConfig. The only contextNavigationScreenRouteConfigis used in is as an intersection with an object, and as such the only relevant portions ofNavigationScreenRouteConfigare the object parts.HEIGHTvariable toHeadertype.NavigationContainerProps, makeonNavigationStateChangeproperty value nullable.PS: if in the future you guys would prefer that I separate these sort of PRs into their constituent parts, let me know.