Skip to content

CardStackTransitioner dropping screenProps #1066

Closed
@coodoo

Description

@coodoo

After switching to the latest master (7165efc at the time of writing), StackNavigator is not passing down screenProps to child screens and breaking a lot of existing code.

Root cause is screenProps not being passed down in CardStackTransitioner, see this line, it should have been {...this.props} instead of {...props}.

Or, at least pass screenProps as below:

return (
  <CardStack
	headerComponent={headerComponent}
	headerMode={headerMode}
	mode={mode}
	router={router}
	cardStyle={cardStyle}
	style={style}
	screenProps={this.props.screenProps}
        {...props}
  />
);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions