Skip to content

Update navigation-prop.md #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Conversation

ayunas
Copy link
Contributor

@ayunas ayunas commented Nov 11, 2019

just a grammatical error. Previous : anything magic here
Propsed change : any magic here

READ ME PLEASE!

TL;DR: Make sure to add your changes to versioned docs

Thanks for opening a PR!

The docs cover several versions of react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").

Please make sure that the edit you're making in docs/file-you-edited.md is also included in the file for the correct version, eg. website/versioned_docs/version-3.x/file-you-edited.md for version 3. If such file doesn't exist, please create it. 👍

just a grammatical error.  Previous :  `anything magic here`
Propsed change : `any magic here`
@satya164 satya164 force-pushed the source branch 5 times, most recently from 8b02cfa to e7a8a2c Compare November 13, 2019 19:45
@WoLewicki
Copy link
Member

You are right. Thanks for the contribution!

@WoLewicki WoLewicki merged commit 07a53c7 into react-navigation:source Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants