Skip to content

Update v3.x docs stack-navigator.md for white space and overlap between headerLeft and headerTitle #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2019

Conversation

ChenhuaWANG22
Copy link

@ChenhuaWANG22 ChenhuaWANG22 commented Dec 24, 2018

add some information for white space or overlap between headerLeft and headerTitle.

website/versioned_docs/version-3.x/stack-navigator.md

Make sure to add your changes to versioned docs

Thanks for opening a PR!

The docs cover several versions of react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe single page of the docs (eg. "Getting Started").

Please make sure that the edit you're making in docs/file-you-edited.md is also included in the file for the correct version, eg. website/versioned_docs/version-3.x/file-you-edited.md for version 3. If such file doesn't exist, please create it. 👍

add some information for white space or overlap between headerLeft and headerTitle.
@react-navigation-bot
Copy link

react-navigation-bot commented Dec 24, 2018

Deploy preview for react-navigation ready!

Built with commit 1827d89

https://deploy-preview-329--react-navigation.netlify.com

@ChenhuaWANG22 ChenhuaWANG22 changed the title Update v3.x docs stack-navigator.md Update v3.x docs stack-navigator.md for white space and overlap between headerLeft and headerTitle Dec 24, 2018
@brentvatne
Copy link
Member

thanks! can you add this change to website/versioned_docs/version-3.x/stack-navigator.md also?

@ChenhuaWANG22
Copy link
Author

thanks! can you add this change to website/versioned_docs/version-3.x/stack-navigator.md also?

This change is in website/versioned_docs/version-3.x/stack-navigator.md.
Or you want me change another file ?

@vonovak
Copy link
Member

vonovak commented Dec 31, 2018

@ChenhuaWANG22 if you take a look at the "files changed" tab, you'll see the change is not made in website/versioned_docs/version-3.x/stack-navigator.md. but in docs/stack-navigator.md . Please add the change there as well. Thanks.

@ChenhuaWANG22
Copy link
Author

ChenhuaWANG22 commented Jan 4, 2019

@vonovak weird, I tried again: change in website/versioned_docs/version-3.x/stack-navigator.md, but when I use "Open a pull request" it still shows update in docs/stack-navigator.md.
See below screenshot.

Did I mistake something?

image

@vonovak
Copy link
Member

vonovak commented Jan 5, 2019

@vonovak vonovak merged commit 78c963e into react-navigation:source Jan 6, 2019
@vonovak
Copy link
Member

vonovak commented Jan 6, 2019

@ChenhuaWANG22 fixed it for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants