Repository navigation
feat: line the exports up with @react-navigation/native and native-stack - #19
Merged
Merged
Conversation
Lines the entry up with @react-navigation/native-stack: the view and the options-callback args are public, the descriptor and helper types are not.
LinkingContext, LocaleDirContext and useLocale (NavigationContainer takes a direction), useLinkTo, useLinkBuilder, useRoutePath, the Material fallback themes, and every type from types. The linking option types move to types so the same export * works.
🦋 Changeset detectedLatest commit: 7eb068b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root export, mirroring
@react-navigation/native:LinkingContext,LocaleDirContext+useLocale(with adirectionprop onNavigationContainer),useLinkTo,useLinkBuilder,useRoutePath,MaterialDarkTheme/MaterialLightTheme, andexport * from './types'(the linking option types move there)./stack, mirroring@react-navigation/native-stack: exportsLynxStackViewandLynxStackOptionsArgs; drops the descriptor and helper types from the public entry.Not ported:
Link/useLinkProps(need a Lynx<text>version),createStandardNavigationFactories(depends onstandard-navigation),useScrollToTop,SFSymbol/MaterialSymbol/CornerInset, and header hooks.Verified on a Pixel 4 XL with the example:
useLinkTo('/detail')navigates,useRoutePath()reports/detail.