Add sub resource SSL error handling on Android #3834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolsoftwaretyler
requested review from
Titozzz and
jamonholmgren
as code owners
Titozzz
approved these changes
Aug 25, 2025
react-native-community-bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
# [13.16.0](v13.15.0...v13.16.0) (2025-08-25) ### Bug Fixes * **android:** revert [#1221](#1221) setIgnoreErrFailedForThisURL ([#3831](#3831)) ([56989ca](56989ca)) * **ios:** Inline CPP operator to avoid duplicate symbols during linking ([#3830](#3830)) ([2ee4218](2ee4218)) * **types:** Make `clearCache` method required instead of optional ([#3818](#3818)) ([dd6fb80](dd6fb80)) ### Features * **android:** Add sub resource SSL error handling on Android ([#3834](#3834)) ([8b96334](8b96334))
|
🎉 This PR is included in version 13.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jiebenjamin90-glitch
added a commit
to jiebenjamin90-glitch/react-native-web-views
that referenced
this pull request
Sep 17, 2025
# [13.16.0](react-native-webview/react-native-webview@v13.15.0...v13.16.0) (2025-08-25) ### Bug Fixes * **android:** revert [#1221](react-native-webview/react-native-webview#1221) setIgnoreErrFailedForThisURL ([#3831](react-native-webview/react-native-webview#3831)) ([56989ca](react-native-webview/react-native-webview@56989ca)) * **ios:** Inline CPP operator to avoid duplicate symbols during linking ([#3830](react-native-webview/react-native-webview#3830)) ([2ee4218](react-native-webview/react-native-webview@2ee4218)) * **types:** Make `clearCache` method required instead of optional ([#3818](react-native-webview/react-native-webview#3818)) ([dd6fb80](react-native-webview/react-native-webview@dd6fb80)) ### Features * **android:** Add sub resource SSL error handling on Android ([#3834](react-native-webview/react-native-webview#3834)) ([8b96334](react-native-webview/react-native-webview@8b96334))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new event handler to the
WebViewcomponent for Android:onLoadSubResourceError, which is fired when the package receives SSL errors where the failing URL does not match the top window URL.Currently,
react-native-webviewsimply logs these out. But I had a use case where I needed to specifically handle these events. This patch works for my use case, and it seems reasonable other people might want something like this as well.A simpler change might be to change
TopLoadingErrorEventto have some value indicating thatfailingUrl !== topWindowUrl, and just route everything through the existing handler. As a starting proposal, I chose to add a separate handler for this because I figured it was more backwards compatible. Happy to iterate on that if the project prefers a different design.I also added a test case that points to
https://badssl.com/. If you runyarn androidto see the Example app and tap around, you'll see the logs coming through:Screen.Recording.2025-08-21.at.8.32.48.PM.mov