Skip to content

Fix issue, when addEventListener('notification') is not called after app was killed/terminated #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix issue, when addEventListener('notification') is not called after app was killed/terminated #65

wants to merge 2 commits into from

Conversation

Andriiklymiuk
Copy link

Fix error, when VoipNotificaiton.addEventListener('notification') is not called, when app was terminated and opened on rnCallKeep call.
this fix initially proposed in #59 thanks to @JJMoon

@Andriiklymiuk
Update RNVoipPushNotificationManager.m
dd2903c 
Fix error, when VoipNotificaiton.addEventListener('notification') is not called, when app was terminated and opened on rnCallKeep call. 
this fix initially proposed in react-native-webrtc#59 thanks to @JJMoon
@Andriiklymiuk
Update RNVoipPushNotificationManager.m
0f10843
@Andriiklymiuk Andriiklymiuk changed the title Update RNVoipPushNotificationManager.m Fix issue, when addEventListener('notification') is not called after app was killed/terminated Oct 22, 2020
@zxcpoiu zxcpoiu mentioned this pull request Nov 17, 2020
Merged
@zxcpoiu
Copy link
Member

zxcpoiu commented Nov 17, 2020

This is an uncertain workaround. #61 is a proper fix. But now in favor of #69, you can take a look and test.

@zxcpoiu zxcpoiu closed this Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andriiklymiuk @zxcpoiu