This repository was archived by the owner on Jan 31, 2026. It is now read-only.
fix(android): update build.gradle for RN 0.74+ compatibility - #577
Merged
safaiyeh merged 1 commit intoDec 27, 2025
Merged
Conversation
Member
|
thank you @1mehdifaraji! added a revive tag, I will merge this in once I upgrade the repo's tooling |
Member
|
@greptile review |
Greptile SummaryThis PR modernizes the Android build configuration for React Native 0.74+ by removing the outdated Key Changes:
Impact:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant RootProject as Root Project build.gradle
participant LibModule as Library Module build.gradle
participant AGP as Android Gradle Plugin
participant Gradle as Gradle 8.x
Note over RootProject,Gradle: Before: Hardcoded AGP 7.2.1
RootProject->>LibModule: buildscript block executes
LibModule->>AGP: Force download AGP 7.2.1
AGP-->>LibModule: TLS handshake failures (via proxy/VPN)
LibModule->>Gradle: Attempt build
Gradle-->>LibModule: Resource merging errors (missing packaging config)
Note over RootProject,Gradle: After: Inherit Modern AGP
RootProject->>LibModule: Apply plugins (com.android.library, kotlin-android)
LibModule->>AGP: Inherit AGP version from root (8.x+)
AGP-->>LibModule: Modern AGP loaded successfully
LibModule->>Gradle: Build with packaging excludes
Note over LibModule,Gradle: packaging.resources.excludes handles META-INF conflicts
Gradle-->>LibModule: Build succeeds cleanly
|
Greptile found no issues!From now on, if a review finishes and we haven't found any issues, we will not post anything, but you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
safaiyeh
self-requested a review
December 27, 2025 21:20
safaiyeh
approved these changes
Dec 27, 2025
safaiyeh
pushed a commit
that referenced
this pull request
Dec 27, 2025
# [3.3.0](v3.2.4...v3.3.0) (2025-12-27) ### Bug Fixes * **android:** update build.gradle for RN 0.74+ compatibility ([#577](#577)) ([13f6dce](13f6dce)) * **Expo:** Config plugin setup ([#543](#543)) ([c33c67d](c33c67d)) * fix illegal type in boxed expression ([#452](#452)) ([32aab8b](32aab8b)) * **ios:** correctly link frameworks required ([#535](#535)) ([2a7d27a](2a7d27a)) ### Features * **iOS:** Enable file transcriptions ([#409](#409)) ([03da891](03da891))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
android/build.gradleto resolve common build issues in modern React Native versions (0.74+):buildscriptblock, which forces downloading AGP 7.2.1 (causing TLS handshake failures via proxies/VPNs). Now inherits the root project's modern AGP (8.x+).packagingoptions to fix resource merging errors in Gradle 8+ (e.g., duplicate META-INF files).Tested on RN 0.75: Builds cleanly without patches.
Please consider publishing a new npm version after merge (last release was v3.2.4 in 2022—many users install from GitHub master due to outdated npm).