Skip to content

Conversation

@harish92
Copy link
Contributor

Overview

Test Plan

harish92 added 2 commits July 21, 2021 15:21
feat: added telegram share
added type telegram
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Very cool.

Seems like this needs a related documentation update https://github.com/react-native-share/react-native-share/blob/master/website/docs/share-single.mdx#supported-applications

Any plans on implementing iOS so it's cross-platform?

feat: updated docx telegram share
@harish92
Copy link
Contributor Author

Thanks,
Sorry, no plans yet implementing on IOS. Sure will do it in the future.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - and re: iOS, adding support there would be fabulous but I am always a fan of incremental progress (as long as limitations are documented, which they are now - thank you!) so that wouldn't stop me from merging. @MateusAndrade should hit the merge button though I think lest I have missed something

@MateusAndrade
Copy link
Collaborator

Nice! Everything looks great. Thanks a lot @harish92! 🚀

@MateusAndrade MateusAndrade merged commit 4e4c7d1 into react-native-share:master Jul 21, 2021
MateusAndrade pushed a commit that referenced this pull request Jul 21, 2021
# [6.4.0](v6.3.0...v6.4.0) (2021-07-21)

### Features

* added single share feature for telegram ([#1058](#1058)) ([4e4c7d1](4e4c7d1))
@MateusAndrade
Copy link
Collaborator

🎉 This PR is included in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mobiledev7 added a commit to mobiledev7/react-native-share that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants