Skip to content

Conversation

tran2
Copy link
Contributor

@tran2 tran2 commented Jun 16, 2022

The fix is based on fixes from this issue: expo/expo#15649

@tran2 tran2 requested a review from Naturalclar as a code owner June 16, 2022 00:16
@tran2
Copy link
Contributor Author

tran2 commented Jun 30, 2022

upgraded slipper so that ios build would work

@Yandamuri
Copy link

@tran2 still facing the same issue expo/expo#15649

I am using `"@react-native-community/progress-view": "1.3.1"

When would the change be merged?

@tran2
Copy link
Contributor Author

tran2 commented Jul 7, 2022

@Naturalclar could you approve running the workflow to see if this fixes the ios build? Thanks!

@Yandamuri
Copy link

@Naturalclar could you approve running the workflow to see if this fixes the ios build? Thanks!

Any update on this? eagerly waiting for this update.

@Yandamuri
Copy link

@Naturalclar could you approve running the workflow to see if this fixes the ios build? Thanks!

Any update on this? eagerly waiting for this update.

May I hear any update on this?

I can proceed for further only if this progressView issue is resolved.

@Yandamuri
Copy link

@Naturalclar could you approve running the workflow to see if this fixes the ios build? Thanks!

@Naturalclar @tran2

May I hear any update on this?

I can proceed for further in my project only if this progress-view issue is resolved.

@Naturalclar
Copy link
Member

@Yandamuri @tran2 sorry for the late response, I've just approved the CI run

@Yandamuri
Copy link

@Yandamuri @tran2 sorry for the late response, I've just approved the CI run

@Naturalclar Thank you so much for your prompt response🙂.

May I know when will master branch be merged?

Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Naturalclar Naturalclar merged commit 2519141 into react-native-progress-view:master Jul 16, 2022
@Yandamuri
Copy link

@Naturalclar Thank you for approving the changes.

I have done changes in /node_modules/@react-native-community/progress-view/ios/RNCProgressView.h as per this commit and I can confirm that this commit resolves the issue.

Now, My doubt is which version of @react-native-community/progress-view resolves this? Because v1.3.1 is still giving me the issue unless I do changes in /node_modules/@react-native-community/progress-view/ios/RNCProgressView.h.

@Yandamuri
Copy link

@Naturalclar Thank you for approving the changes.

I have done changes in /node_modules/@react-native-community/progress-view/ios/RNCProgressView.h as per this commit and I can confirm that this commit resolves the issue.

Now, My doubt is which version of @react-native-community/progress-view resolves this? Because v1.3.1 is still giving me the issue unless I do changes in /node_modules/@react-native-community/progress-view/ios/RNCProgressView.h.

@Naturalclar Can you please comment over this?

@Naturalclar
Copy link
Member

@Yandamuri sorry for the late response. The fix is included in v1.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants