Skip to content

Conversation

TatianaKapos
Copy link
Contributor

@TatianaKapos TatianaKapos commented Dec 17, 2021

Left in Draft State until majority of team is back from holidays and can review :)

Why

Resolves #77. The windows example app was currently broken with the steps listed in the repo and needed to be updated to RNW .64 to fix Folly error of not working with latest version of VS (microsoft/react-native-windows-samples#327) and also removes an unnecessary step to run the example app.

Description

Updates the example app to RNW .64

Testing

Tested locally. Windows CI on this repo is currently broken

image

@TatianaKapos
Copy link
Contributor Author

It looks like the ios CI may be broken too.

@TatianaKapos TatianaKapos changed the title [DRAFT] Fixes windows example Updates Window Example to RNW .64 Jan 4, 2022
@TatianaKapos TatianaKapos marked this pull request as ready for review January 4, 2022 18:35
Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TatianaKapos Thank you so much! Sorry for the delay

@Naturalclar Naturalclar merged commit eb7248f into react-native-progress-view:master Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example app is outdated/broken for Windows
2 participants