Remove references to example folder in vcxproj #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2020 12:27
MicrosoftNik
changed the title
asklar
approved these changes
Oct 15, 2020
Naturalclar
approved these changes
Oct 17, 2020
|
Just published v1.2.2 with this fix 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, manually linking the react-native-progress-view to a react-native-windows project requires additional modifications to the vcxproj file located in the node_modules while other projects such as Picker do not. Problems with the Nuget packages arise when building due to the vcxproj file pointing to an example folder which does not exist in the published package.
Test Plan:
Tested both example project and Manual linking steps described in the README after installing the package in a project created with these steps.