Added Windows Tests #40
Conversation
test from react-native-webview
…tianaKapos-Adding-WindowsTest
.eslintignore
Outdated
| jest-setups/jest.setup.js | ||
| jest-setups/jest.setup.windows.js | ||
| __tests__/ProgressViewWindows.test.js |
There was a problem hiding this comment.
I removed the test file from this file but both jest-setup files gives me a 'platform' is not defined no-undef error even though it's defined in the setup.windows
.github/workflows/windows-ci.yml
Outdated
| - name: NuGet restore | ||
| run: nuget restore example\windows\ProgressViewExample.sln | ||
|
|
||
| - name: Build x64 release | ||
| run: msbuild .\example\windows\ProgressViewExample.sln /p:Configuration=Release /p:Platform=x64 -m | ||
|
|
||
| - name: Deploy | ||
| shell: powershell | ||
| run: | | ||
| cd example | ||
| Copy-Item -Path windows\x64\Release -Recurse -Destination windows\ | ||
| npx react-native run-windows --arch x64 --release --no-build --no-packager |
There was a problem hiding this comment.
sorry let me rephrase: can we just replace all of this with just running yarn windows or npx react-native run-windows?
There was a problem hiding this comment.
I remember seeing some bundling errors when building release using just run-windows command, maybe that's fixed now. @TatianaKapos you can try replacing all this with npx react-native run-windows --arch x64 --release --no-packager and see if it works.
There was a problem hiding this comment.
hmmm yeah I'm seeing an error where it can't find the package in the release folder :/
|
@Naturalclar This PR had been reviewed, let me know if you need me to make any changes! :) |
|
I was looking to add the Windows state to reactnative.directory, but it appears that we need a new published update that this contains this merged PR. In particular to address the part to fix the package files that was originally a separate PR but then was included in this PR. The change is in, there just needs to be a new publish to NPM. @Naturalclar are releases being done on demand? What's the criteria for pushing out a new one? @TatianaKapos Did we get validation that if the |
|
@chrisglein I can release the package on demand. I thought the PR only added test and no change to the actual functionality of the code, so I didn't make a release, sorry about that! |
|
My bad, should have specified the fix in the PR! But I just checked and it fixes the windows issue. |
|
@TatianaKapos we miss youuuuuuu |
Summary
Added Windows tests to ProgressView
Checklist
README.mdCHANGELOG.mdexample/App.js)