-
Notifications
You must be signed in to change notification settings - Fork 59
Fabric support #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fabric support #101
Conversation
8ddbd9e
to
9b50a0e
Compare
"dependencies": { | ||
"react": "18.1.0", | ||
"react-native": "0.70.1", | ||
"@react-native-community/progress-view": "link:../" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using link: protocol, will need to update metro.config.js
to watch the whole repo and blacklist react-native but it will make yarn install
faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM
Hi @zabojad there might be some change to support react-native 0.72 (I suspected it change the generated files slightly difference). It might requires an update for this library to support newer version. |
This pull request resolves #91
Description
Support for Fabric in iOS and Android.
JS changes
requireNativeComponent
to separate file and migrate tocodegenNativeComponent
Cpp changes
common/cpp
iOS supports setting an image as a background of progress. It's a bit tricky to add, but I follow the solution from reactwg/react-native-new-architecture#31 (comment) which requires implementing image loading in c++ layer. Another solution is reactwg/react-native-new-architecture#31 (reply in thread) which looks cleaner and won't impact Android but it have to import
RCTBridge+Private.h
so I choose to implement c++ instead, can let me know which one you prefer.iOS changes
Android Changes
RNCProgressViewManagerImpl
Breaking change:
It should support both old architecture and new architecture. But requires bumping minimum RN version and minimum iOS version
Affected platforms
Test plan/screenshots/videos
I created
fabric-example/
for testing out fabric using RN 0.70 (+ react-native-test-app).Paper
Fabric