Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement rtl support for android picker #243

Conversation

mateusz1913
Copy link
Contributor

Hi, I added rtl support for android picker. To test that you can open example app and toggle switch which will trigger I18nManager.forceRTL method, after that app needs to be reloaded (neither state change, nor fast refresh does not work).

Closes #218

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mateusz1913 LGTM! thanks so much 👍🏻

@Naturalclar Naturalclar changed the title feat(#218): implement rtl support for android picker feat: implement rtl support for android picker Apr 12, 2021
@Naturalclar Naturalclar merged commit ce376c2 into react-native-picker:master Apr 12, 2021
github-actions bot pushed a commit that referenced this pull request Apr 12, 2021
# [1.15.0](v1.14.0...v1.15.0) (2021-04-12)

### Features

* implement rtl support for android picker ([#243](#243)) ([ce376c2](ce376c2))
@Naturalclar
Copy link
Contributor

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mateusz1913 mateusz1913 deleted the feat/218-android-rtl-support branch September 18, 2021 17:22
@mahmoudadel2231
Copy link

the issue still exists I have the latest version in android, it doesn't change the direction

@Alarees
Copy link
Contributor

Alarees commented Nov 28, 2022

the issue still exists I have the latest version in android, it doesn't change the direction

yes, but you need to add android:supportsRtl="true" in the application tag in AndroidManifest.xml file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTL Support
4 participants