fix(android): crash when library try to access JSModule before it is initialized (oblador#107)

Harsh0 · web-flow · commit 98746a956e18 · 2024-03-08T21:13:13.000+01:00
Co-authored-by: Harsh Singhal &lt;hsnghal@amazon.com&gt;
diff --git a/packages/react-native-performance/android/src/main/java/com/oblador/performance/PerformanceModule.java b/packages/react-native-performance/android/src/main/java/com/oblador/performance/PerformanceModule.java
@@ -187,9 +187,11 @@ private void emit(PerformanceMetric metric) {
             WritableMap map = Arguments.fromBundle(metric.getDetail());
             params.putMap("detail", map);
         }
-        getReactApplicationContext()
-                .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
-                .emit("metric", params);
+        if (getReactApplicationContext().hasActiveCatalystInstance()) {
+            getReactApplicationContext()
+                    .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
+                    .emit("metric", params);
+        }
     }
 
     private void emit(PerformanceMark mark) {

Original file line number	Diff line number	Diff line change
`@@ -187,9 +187,11 @@ private void emit(PerformanceMetric metric) {`
`187`	`187`	`WritableMap map = Arguments.fromBundle(metric.getDetail());`
`188`	`188`	`params.putMap("detail", map);`
`189`	`189`	`}`
`190`		`- getReactApplicationContext()`
`191`		`- .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)`
`192`		`- .emit("metric", params);`
	`190`	`+ if (getReactApplicationContext().hasActiveCatalystInstance()) {`
	`191`	`+ getReactApplicationContext()`
	`192`	`+ .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)`
	`193`	`+ .emit("metric", params);`
	`194`	`+ }`
`193`	`195`	`}`
`194`	`196`
`195`	`197`	`private void emit(PerformanceMark mark) {`