Skip to content

Follow up to "Make the ACCESS_WIFI_STATE permission optional" #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

sweggersen
Copy link
Contributor

@sweggersen sweggersen commented Jun 23, 2020

Overview

Fixes #353

Added additional check for permission.

Test Plan

Tested locally

@sweggersen sweggersen requested a review from matt-oakes as a code owner June 23, 2020 09:25
@sweggersen sweggersen changed the title Add another check in ConnectivityReciever to make sure we have ACCESS… Follow up to "Make the ACCESS_WIFI_STATE permission optional Jun 23, 2020
@sweggersen sweggersen changed the title Follow up to "Make the ACCESS_WIFI_STATE permission optional Follow up to "Make the ACCESS_WIFI_STATE permission optional" Jun 23, 2020
Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, with the appropriate refactor too, LGTM

@matt-oakes matt-oakes merged commit b0ff1ff into react-native-netinfo:master Jun 25, 2020
react-native-community-bot pushed a commit that referenced this pull request Jun 25, 2020
## [5.9.4](v5.9.3...v5.9.4) (2020-06-25)

### Bug Fixes

* **android:** Add another check in ConnectivityReciever to make sure we have ACCESS_WIFI_STATE permission ([#379](#379) by [@sweggersen](https://github.com/sweggersen)) ([b0ff1ff](b0ff1ff))
@react-native-community-bot
Copy link
Collaborator

🎉 This PR is included in version 5.9.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 5.7.0 feature "android: Make the ACCESS_WIFI_STATE permission optional" seems incomplete
4 participants