Skip to content

chore: Update example to react-native 0.72 #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 15, 2023
Merged

chore: Update example to react-native 0.72 #583

merged 7 commits into from
Sep 15, 2023

Conversation

alphatrl
Copy link
Contributor

Overview

This PR updates the example app to react-native@0.72 allowing it to be run on an Apple Silicon Mac and Xcode 14.3.

The example directory has been regenerated using a more recent version of react-native-test-app which supports 0.72, resulting in a large number of file changes.

example/index.tsx has been renamed to example/index.js to allow yarn build:android and yarn build:ios to build without errors.

Test Plan

Run yarn example ios and yarn example android successfully

example-ss

Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM 👍

@Naturalclar Naturalclar merged commit 76ddefa into react-native-menu:master Sep 15, 2023
@alphatrl alphatrl deleted the amos/upgrade-example-app-to-rn-72 branch September 15, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants