This repository has been archived by the owner on Mar 30, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A breakdown of everything this PR achieves:
Dark Mode Switch
component and the Divider in the side-drawerCheckbox
page became invisible in Dark Mode, as the color of theunCheckedIcon
was black. It has been converted to grey to be visible in both Dark and Light Modes.Inputs
page have been replaced with the standard SubHeader. This is to ensure uniformity.Lists
page have been fixed.Overlay
page to look similar to the image in the documentation.ItemSeparatorComponent
in theSettings Example
had only one color, and hence in Dark Mode, the white color (used to make LightMode look similar to iOS settings) caused problems by looking out of place. To fix it, I have added conditional rendering which changes this component's color to black in Dark mode and white in Light Mode. Now, the page replicates the iOS look perfectly in both modes.Text
page to de-clutter the components from the top.Find out More
component inTiles
is changed from dark blue as it looked a bit weird in Dark Mode.Open to suggestions, and willing to implement them immediately 🙌🏻