This repository was archived by the owner on Mar 30, 2022. It is now read-only.
Addition of Dialogs Page #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ative-elements-app into dialog
|
That looks great. It looks like you tried to update the yarn.lock file, so now this is out of date. |
|
I just pulled the current yarn.lock file in the repository and pushed it to my fork. Ready to review! |
|
Same here, the lock file is off now. |
|
what would you suggest would be the best way to resolve this? |
|
Okay, I figured it out. I just fetched it from upstream. There are no more changes to yarn.lock in the PR |
…ative-elements-app into dialog
|
Hey @flyingcircle! Kindly merge this PR along with react-native-elements/react-native-elements#2911 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upon implementation of the new Dialog component, introduced in this Issue and implemented in this PR, I have incorporated this into the demo app with a new page dedicated to dialogs and their different types. Here's a quick look at what it looks like: