fix loading style in socialicon

[ankushdutt]

fixes #51

[netlify]

Deploy preview for rne-playground ready!

Built with commit c5a3207

https://deploy-preview-52--rne-playground.netlify.app

[Uyadav207]

Problem

• The icon still shows beside the loading icon.
• when onLoading: {true} && icon: {true} then icon and blank svg img is visible.

Possible Solution

• please try to use Conditional Rendering.
• This can be done using a ternary operator.

[ankushdutt]

fixed the loading issue here (react-native-elements/react-native-elements#2846)
Added the activityIndicatorStyle for socialicons to the playground here, so we can merge this one too
@pranshuchittora

[pranshuchittora]

@ankushdutt thanks for finding the issue and fixing the same in the core.
Is activityIndicatorStyle is a new prop ?

If yes, then pls add the same to the docs (https://github.com/react-native-elements/react-native-elements/tree/next/website/docs/props) so that it can be automatically pulled in the Playground via #15

[ankushdutt]

Is activityIndicatorStyle is a new prop ?

No, it was already present in the codebase of React Native Elements Core (I haven't added them in my fix there). Though, its not present in SocialIcon docs

Alright, I'll make a PR for the missing props in the core.

[pranshuchittora]

Did you made a PR for the activityIndicatorStyle

[ankushdutt]

Did you made a PR for the activityIndicatorStyle

Yes, here: react-native-elements/react-native-elements#2946