Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating the ISSUE_TEMPLATE for contributions. #36

Merged

Conversation

Uyadav207
Copy link
Contributor

This PR is regarding #24 issue,

Need

  • Necessary for an OSS project
  • Helps maintainer as well contributor to have more specificity.

@pranshuchittora, please let me know if the PR is Good to merge.

Thanks :)

@netlify
Copy link

netlify bot commented Mar 11, 2021

Deploy preview for rne-playground ready!

Built with commit bd7c10c

https://deploy-preview-36--rne-playground.netlify.app

<!--
Example:

```bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why code block

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranshuchittora , actually the steps.... need to be hidden, so only commenting the steps didn't worked.. I have wrapped the steps in a code block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranshuchittora , May I change or leave it as it is ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the code block and it should be outside the comment as
1.
2.
3.

Like this without any content

1.
2.
3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok will do it asap

@Uyadav207
Copy link
Contributor Author

Done with changes, @pranshuchittora

@pranshuchittora
Copy link
Member

Just skimmed over the content.
LGTM 👍
Thanks

@pranshuchittora pranshuchittora merged commit 253bd2e into react-native-elements:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants