fix issue #126 #992
Merged
fix issue #126 #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonovak
reviewed
Jul 24, 2025
Member
vonovak
left a comment
vonovak
left a comment
There was a problem hiding this comment.
hi! Thanks for the PR, this looks okay!
Can you please check whether maxDate prop needs the same treatment?
Thank you!
Contributor
Author
|
Hi! Thanks for the review and the suggestion! I checked the maxDate behavior, and no additional handling is needed. If maxDate falls between intervals — for example, 18:29 with a minuteInterval of 15 — the picker automatically rounds down to the closest valid value (18:15 in this case), so it doesn’t allow values beyond maxDate. I’ll attach a short video as a reference. Thanks again! Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-07-28.at.16.30.58.mp4 |
vonovak
approved these changes
Jul 28, 2025
Member
|
Than you! |
vonovak
pushed a commit
that referenced
this pull request
Jul 28, 2025
## [8.4.3](v8.4.2...v8.4.3) (2025-07-28) ### Bug Fixes * **ios:** minuteInterval breaks minimumDate ([#992](#992)) ([5266faf](5266faf))
Member
|
🎉 This issue has been resolved in version 8.4.3 🎉 If this package helps you, consider sponsoring us! 🚀 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #126 .
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)