Skip to content

fix(ios): fix min/max date crash #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
foyarash wants to merge 2 commits into from
Closed

fix(ios): fix min/max date crash #1008

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5268442
fix(ios): fix min/max date crash
foyarash Sep 8, 2025
2a07f4e
fix typo
foyarash Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions ios/fabric/RNDateTimePickerComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
if (minuteInterval <= 0) {
return minimumDate;
}

NSInteger minute = [[NSCalendar currentCalendar] component:NSCalendarUnitMinute fromDate:minimumDate];
NSInteger remainder = minute % minuteInterval;
NSInteger adjustment = (remainder == 0) ? 0 : (minuteInterval - remainder);
Expand Down Expand Up @@ -175,12 +175,20 @@ - (Boolean)updatePropsForPicker:(UIDatePicker *)picker props:(Props::Shared cons
}

if (oldPickerProps.minimumDate != newPickerProps.minimumDate) {
NSDate *minimumDate = convertJSTimeToDate(newPickerProps.minimumDate);
picker.minimumDate = adjustMinimumDate(minimumDate, newPickerProps.minuteInterval);
if (newPickerProps.minimumDate == 0.0) {
picker.minimumDate = nil;
} else {
NSDate *minimumDate = convertJSTimeToDate(newPickerProps.minimumDate);
picker.minimumDate = adjustMinimumDate(minimumDate, newPickerProps.minuteInterval);
}
}

if (oldPickerProps.maximumDate != newPickerProps.maximumDate) {
picker.maximumDate = convertJSTimeToDate(newPickerProps.maximumDate);
if (newPickerProps.maximumDate == 0.0) {
picker.maximumDate = nil;
} else {
picker.maximumDate = convertJSTimeToDate(newPickerProps.maximumDate);
}
}

if (oldPickerProps.locale != newPickerProps.locale) {
Expand Down Expand Up @@ -313,4 +321,3 @@ - (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &
{
return RNDateTimePickerComponentView.class;
}